Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate markers under environment with empty "extra" #550

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

MrMino
Copy link
Contributor

@MrMino MrMino commented May 18, 2022

Closes #548.

This required removing code that raised UndefinedEnvironmentName exception (see comment). The class declaration has been left as to not introduce a breaking change in the interface.

@MrMino MrMino force-pushed the empty-extras-are-default branch 3 times, most recently from d4b6dea to cda2a0a Compare May 18, 2022 20:40
@pradyunsg pradyunsg enabled auto-merge (squash) June 2, 2022 15:01
@pradyunsg pradyunsg merged commit 1aa82a8 into pypa:main Jun 2, 2022
@@ -110,6 +109,7 @@ def test_matches_expected(self):
)

assert environment == {
"extra": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since default_environment is part of the public API (pending documentation #503), I wonder if we should avoid adding extra to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate marker environment with extra as "" by default
4 participants